Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ingredient containers from frontier #2504

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

Stop-Signs
Copy link
Contributor

About the PR

Ported salt, pepper, and cocoa containers from frontier (with permission from dvir)
added them to chefvend

Why / Balance

they are cool and a lot of recipes require salt pepper and cocoa so it makes sense!

Technical details

Media

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑

  • add: Added salt, pepper, and cocoa containers to the chefvend

@Stop-Signs Stop-Signs requested review from a team as code owners December 21, 2024 22:47
@github-actions github-actions bot added S: Needs Review Changes: YML Changes any yml files Changes: Sprite Changes any png or json in an rsi size/M 64-255 lines labels Dec 21, 2024
Copy link
Contributor

github-actions bot commented Dec 21, 2024

RSI Diff Bot; head commit 52cf790 merging into 6a74aa3
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Consumable/Food/ingredients.rsi

State Old New Status
cocoa-chip-big Added
pepper-big Added
salt-big Added

Edit: diff updated after 52cf790

Copy link
Member

@IamVelcroboy IamVelcroboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to the spawner Resources/Prototypes/Entities/Markers/Spawners/Random/Food_Drinks/food_ingredients.yml

Lyndomen
Lyndomen previously approved these changes Dec 22, 2024
Copy link
Contributor

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

frontier is a gold mine, approved

@Stop-Signs
Copy link
Contributor Author

Stop-Signs commented Dec 23, 2024

Add to the spawner Resources/Prototypes/Entities/Markers/Spawners/Random/Food_Drinks/food_ingredients.yml

id personally not like this in that specific spawner, just because salt, pepper, and cocoa are moreso things that are normally near impossible to get more of, which is an issue that putting them in the vend fixes. i think it would be better for chefs to get the items that are already in that spawner, which can all be mixed with water to get a ton of food, rather than these items.

@IamVelcroboy
Copy link
Member

Add to the spawner Resources/Prototypes/Entities/Markers/Spawners/Random/Food_Drinks/food_ingredients.yml

id personally not like this in that specific spawner, just because salt, pepper, and cocoa are moreso things that are normally near impossible to get more of, which is an issue that putting them in the vend fixes. i think it would be better for chefs to get the items that are already in that spawner, which can all be mixed with water to get a ton of food, rather than these items.

I'm saying in addition to the vendor, they should be in the rng spawner as well

@IamVelcroboy
Copy link
Member

Bags of salt/pepper could replace the shakers. Cocoa should be added to the other bags of dry stuff, like flour/rice/sugar/etc. You can give it a lower probability if you want. But it should be in there

IamVelcroboy
IamVelcroboy previously approved these changes Jan 2, 2025
@deltanedas deltanedas enabled auto-merge (squash) January 3, 2025 19:06
@deltanedas deltanedas merged commit 8203bf6 into DeltaV-Station:master Jan 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review size/M 64-255 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants